cleanup LangOptions #28457
Merged
cleanup LangOptions #28457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Build failed |
compnerd
force-pushed
the
basic-cleanup
branch
from
9e4634c to
1808f5b
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
Switch over `Triple::getOS` instead of a series of cascading `if`s. This simplifies the handling of adding new entries. It also makes the precedence ordering more explicit.
Collapse the cases into a single set rather than adding a case for each entry. This is easier to read/follow. NFC.
Rather than an if repeating the condition, simplify using a ternary for the value. NFC.
The platform versions are really only used on Darwin platforms. Simplify the path by defaulting to `0.0.0` on all platforms, and handling the version number on supported platforms.
compnerd
force-pushed
the
basic-cleanup
branch
from
1808f5b to
851f877
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@dgregor what do you think? |
|
I have a building backlog of patches. I'd like to get this merged so I can start flushing them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.