[build-script-impl] Optimize setting -> variable name lookups. #2847
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The current behavior of mapping via `tr` was very slow when called over and
over for each option. This matters for SR-237 where I would like
`build-script` to take over the top-level build process control loop, which
involves executing `build-script-impl` multiple times.
- This patch optimizes the lookup in two ways:
1. It does the setting to variable conversion in a single pass, for all
options at once.
2. It builds a cache of the setting to variable name conversion (as an
exploded associate array), and uses that when doing variable assignment.
- This patch speeds up `build-script-impl --dry-run` by 2x on one test case.
|
/cc @gribozavr @swift-ci please smoke test |
1 task
|
LGTM! |
ddunbar
deleted the
build-script-impl-optimize-setting-to-variable-lookups
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
This optimizes
build-script-impl's setting processing code (which was adding about 1s to each invocation, on my machine). See commit for details.Related to SR-237.
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.
trwas very slow when called over andover for each option. This matters for SR-237 where I would like
build-scriptto take over the top-level build process control loop, whichinvolves executing
build-script-implmultiple times.options at once.
exploded associate array), and uses that when doing variable assignment.
build-script-impl --dry-runby 2x on one test case.