[AutoDiff] Update differentiableFunction(from:) to use differentiable function constructor builtins.
#28470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le function constructor builtins. This PR updates `differentiableFunction(from:)` to use differentiable function constructor builtins added in swiftlang#28467. The standard library no longer has non-top-level derivative registration. Resolves SR-11847. Unblocks SR-11849.
dan-zheng
approved these changes
Nov 25, 2019
| @@ -212,39 +212,36 @@ public func withoutDerivative<T, R>(at x: T, in body: (T) -> R) -> R { | |||
| /// Create a differentiable function from a vector-Jacobian products function. | |||
| @inlinable | |||
| public func differentiableFunction<T : Differentiable, R : Differentiable>( | |||
| from vjp: @escaping (T) | |||
| from vjp: __owned @escaping (T) | |||
There was a problem hiding this comment.
I wonder if __owned convention is necessary to use Builtin.differentiableFunction?
There was a problem hiding this comment.
No, it’s not necessary. It’s just a library optimization.
There was a problem hiding this comment.
Well, I removed it because there's a bug that causes it not to parse when it's used with @escaping.
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
1 similar comment
|
@swift-ci please test tensorflow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
differentiableFunction(from:)to use differentiable function constructor builtins added in #28467. The standard library no longer has non-top-level derivative registration.Resolves SR-11847. Unblocks SR-11849.