Skip to content

[AutoDiff] Make transpose(of:) available. #28471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Conversation

rxwei
Copy link
Contributor

@rxwei rxwei commented Nov 25, 2019

Depends on #28469. Resolves SR-11845.

Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool!

@rxwei
Copy link
Contributor Author

rxwei commented Nov 25, 2019

@swift-ci please test tensorflow

3 similar comments
@rxwei
Copy link
Contributor Author

rxwei commented Nov 25, 2019

@swift-ci please test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Nov 25, 2019

@swift-ci please test tensorflow

@rxwei
Copy link
Contributor Author

rxwei commented Nov 25, 2019

@swift-ci please test tensorflow

@rxwei rxwei merged commit e1514cf into swiftlang:tensorflow Nov 25, 2019
@rxwei
Copy link
Contributor Author

rxwei commented Nov 26, 2019

This helped discover a serious bug: SR-11856. Arguments being passed to transpose(of:) need to be reabstracted most of the time, but AD reabstraction thunk generation currently treats all differentiable functions as having Normal differentiability (disregarding linearity) and emits incorrect code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants