Skip to content

Cleanup: move ArrayPropertyOpt out of COWArrayOpt.cpp. #28473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Cleanup: move ArrayPropertyOpt out of COWArrayOpt.cpp. #28473

merged 1 commit into from
Dec 3, 2019

Conversation

atrick
Copy link
Contributor

@atrick atrick commented Nov 25, 2019

These are separate, mostly unrelated passes. Putting them in their own
files makes it easier to read the code, understand how to control the
passes, and makes it possible to independently trace, and debug them.

These are separate, mostly unrelated passes. Putting them in their own
files makes it easier to read the code, understand how to control the
passes, and makes it possible to independently trace, and debug them.
@atrick atrick requested a review from aschwaighofer November 25, 2019 19:58
@atrick
Copy link
Contributor Author

atrick commented Nov 25, 2019

@swift-ci test

Copy link
Contributor

@aschwaighofer aschwaighofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atrick
Copy link
Contributor Author

atrick commented Dec 3, 2019

This is part of my work to consolidate SILCloner logic and fully ban address-type block args.

@atrick
Copy link
Contributor Author

atrick commented Dec 3, 2019

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit f0157b0 into swiftlang:master Dec 3, 2019
@atrick atrick deleted the arrayproperty-opt branch December 23, 2019 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants