[Diagnostics] Don't include @unknown default in the empty switch fix-it #28476
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since the bug report mentions frozen enums, could you add some test cases for frozen enums as well? Perhaps 3 test cases: (1) same module + not inlinable (2) same module + inlinable (3) different module. In all three cases, there shouldn't be any |
owenv
force-pushed
the
at_unknown_fix_2
branch
from
8c8ec6a to
12deb51
Compare
owenv
force-pushed
the
at_unknown_fix_2
branch
from
12deb51 to
daed7a0
Compare
|
@varungandhi-apple 👍 , done. I think the bug report was referring more to implicitly frozen enums in the same module, but it never hurts to have the extra test coverage. |
|
@swift-ci please smoke test |
|
@swift-ci please smoke test and merge |
1 similar comment
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SR-11672. This turned out to only affect the fix-it for empty switch statements, which is why the existing tests didn't catch it.