[Runtime] memset ExtraData fully before copy from pattern. #28478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
varungandhi-apple
changed the title
rjmccall
approved these changes
Dec 3, 2019
There was a problem hiding this comment.
Substantively approved, but because this may affect future uses, please add a comment in the following two places saying that versions of the runtime prior to Swift 5.2 are known to not properly zero the zero prefix of the extra-data pattern:
- in Metadata.h on
getExtraDataPattern() - in GenMeta.cpp in
GenericMetadataBuilderBase::layout()where it adds the extra-data pattern
Testing this is possible but probably excessively annoying.
The third argument of memset needs a size in *bytes* not words.
|
Added a comment explaining this and linked to it from the places you mentioned. @swift-ci please test |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Test failure is due to another issue. Fix is in #28542. |
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The third argument of
memsetneeds a size in bytes, not words.