[CS] Enforce that withPathElement is called on an lvalue #28498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Locator builders keep a pointer to their underlying locator, so it's not generally sound to extend an rvalue locator builder. This commit enforces that withPathElement is called on an lvalue, and adds a couple more overloads of getConstraintLocator to make it more convenient to extend locators with multiple elements.
|
@swift-ci please test |
xedin
approved these changes
Dec 2, 2019
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Locator builders store a pointer to their underlying locator, so it's not generally sound to extend an rvalue locator builder (I was recently bit by this when attempting to extend a locator builder with multiple elements).
This PR enforces that
withPathElementis called on an lvalue, and adds a couple more overloads ofgetConstraintLocatorto make it more convenient to extend locators with multiple elements.