Skip to content

[CMake] Fix find_package for libXml2 on case sensitive filesystems. #28504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2019

Conversation

rjmansfield
Copy link
Contributor

This fixes the find_package to work on a case sensitive file system when LLVM_ENABLE_LIBXML2 is true. The cmake finder is FindLibXml2.cmake. Otherwise, if set, the build will fail with:

CMake Error at CMakeLists.txt:929 (find_package):
By not providing "FindLibxml2.cmake" in CMAKE_MODULE_PATH this project has
asked CMake to find a package configuration file provided by "Libxml2", but
CMake did not find one.

Could not find a package configuration file provided by "Libxml2" with any
of the following names:

Libxml2Config.cmake
libxml2-config.cmake

@swift-ci Please smoke test

@CodaFi
Copy link
Contributor

CodaFi commented Nov 29, 2019

Aren’t strings as a universal data type just the greatest.

Thanks for the patch!

@swift-ci please smoke test

@compnerd compnerd merged commit e8e19d4 into swiftlang:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants