[FrondEnd] Wrap RunInmediately() in a stack trace to indicate running user code #28511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e are running user code
|
cc @brentdax Who looked at my PR earlier |
|
@swift-ci please test |
|
@swift-ci Please test Windows platform |
|
Windows CI failures are pre-existing. @swift-ci please smoke test and merge |
beccadax
approved these changes
Dec 2, 2019
|
Thank you @brentdax. Appreciate your help with this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried merging this change earlier in #28284 but was reverted since it caused CI failures here. As a fix, I have added
UNSUPPORTEDfor iOS, watchOS, and tvOS.I am not sure why, but the test just crashes with the following error in those situations:
Resolves SR-11765.