[CS] Coerce dynamic member strings to their param type #28512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
CodaFi
reviewed
Nov 30, 2019
hamishknight
force-pushed
the
stringly-typed
branch
from
3cae4ce to
694b36e
Compare
Move `buildDynamicMemberLookupIndexExpr` into ExprRewriter, and pass the string literal through `handleStringLiteralExpr` to properly handle its coercion to the parameter type.
hamishknight
force-pushed
the
stringly-typed
branch
from
694b36e to
e599c8b
Compare
|
@swift-ci please test |
xedin
approved these changes
Dec 2, 2019
|
@swift-ci please smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were assuming that the string literal argument was always of type
String, however anyExpressibleByStringLiteralparameter is allowed. This PR movesbuildDynamicMemberLookupIndexExprinto ExprRewriter, and passes the string literal throughhandleStringLiteralExprto properly handle its coercion to the parameter type.Resolves SR-11877.