Skip to content

ASTMangler: use specified module names from @_originalDefinedIn to mangle symbols names #28528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

nkcsgexi
Copy link
Contributor

@nkcsgexi nkcsgexi commented Dec 3, 2019

When an original module name is specified via @_originalDefinedIn attribute, we need to
use the original module name for all related runtime symbol names instead of the current
module names.

Needed for rdar://55268186

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Dec 3, 2019

@swift-ci please smoke test

…ngle symbols names

When an original module name is specified via @_originalDefinedIn attribute, we need to
use the original module name for all related runtime symbol names instead of the current
module names.

rdar://55268186
@nkcsgexi nkcsgexi force-pushed the use-alternate-module-name branch from dd2c5d2 to 7e8ed50 Compare December 3, 2019 00:58
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Dec 3, 2019

@swift-ci please smoke test

Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Dec 3, 2019

@swift-ci Please clean test Linux platform

@swift-ci
Copy link
Contributor

swift-ci commented Dec 3, 2019

Build failed
Swift Test Linux Platform
Git Sha - dd2c5d2b50fc5b717a389b08840bc4c6c0b10174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants