Skip to content

[build] allow to skip build of clang-tools-extras #28537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 4, 2019
Merged

[build] allow to skip build of clang-tools-extras #28537

merged 2 commits into from
Dec 4, 2019

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Dec 3, 2019

Also at the same time refactor code that composes LLVM_ENABLE_PROJECTS

Supports rdar://problem/57432088

@edymtt
[build] allow to skip build of clang-tools-extras
f19f978 
Also at the same time refactor code that composes LLVM_ENABLE_PROJECTS

Supports rdar://problem/57432088
@edymtt
Copy link
Contributor Author

edymtt commented Dec 3, 2019

@swift-ci smoketest

@edymtt
Copy link
Contributor Author

edymtt commented Dec 3, 2019

@swift-ci please smoketest

@edymtt
Copy link
Contributor Author

edymtt commented Dec 3, 2019

@swift-ci Please smoke test

@edymtt edymtt requested a review from clackary December 3, 2019 17:58
shahmishal
shahmishal requested changes Dec 3, 2019
View reviewed changes
Copy link
Member

@shahmishal shahmishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add the flags in https://github.com/apple/swift/blob/master/utils/build_swift/driver_arguments.py and add test for this new flag.

@edymtt
Copy link
Contributor Author

edymtt commented Dec 3, 2019

@swift-ci Please smoke test

@edymtt
Copy link
Contributor Author

edymtt commented Dec 3, 2019

@swift-ci Please Python lint

@edymtt
Copy link
Contributor Author

edymtt commented Dec 3, 2019

@swift-ci Please test Windows platform

@edymtt
Copy link
Contributor Author

edymtt commented Dec 3, 2019

Tackled review feedback as part of e5e2743

For the sake of completeness, all build_swift unit tests passes and we have only one unrelated lint failure

>  utils/python_lint.py 
./docs/conf.py:16:1: I201 Missing newline between import groups. 'from sphinx.highlighting import lexers' is identified as Third Party and 'from datetime import date' is identified as Stdlib.
> python -m unittest discover -s utils/build_swift -t utils                                                                                     
........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
----------------------------------------------------------------------
Ran 760 tests in 15.428s

OK

@edymtt edymtt requested a review from shahmishal December 3, 2019 20:16
@edymtt
Copy link
Contributor Author

edymtt commented Dec 3, 2019

@swift-ci Please Python lint

@edymtt
Copy link
Contributor Author

edymtt commented Dec 3, 2019

@swift-ci Please test Windows platform

@edymtt
Copy link
Contributor Author

edymtt commented Dec 3, 2019

@swift-ci please clean test Windows platform

1 similar comment
@edymtt
Copy link
Contributor Author

edymtt commented Dec 3, 2019

@swift-ci please clean test Windows platform

@Rostepher Rostepher self-requested a review December 3, 2019 22:25
Rostepher
Rostepher approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@Rostepher Rostepher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thanks for cleaning this up! 👍

@CodaFi
Copy link
Contributor

CodaFi commented Dec 4, 2019

#28553 addresses the failure here. Thanks!

⛵️

@CodaFi CodaFi merged commit e6cfd51 into swiftlang:master Dec 4, 2019
@edymtt edymtt deleted the skip-clang-tools-extra branch December 4, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rostepher Rostepher Rostepher approved these changes

@compnerd compnerd Awaiting requested review from compnerd

@CodaFi CodaFi Awaiting requested review from CodaFi

@clackary clackary Awaiting requested review from clackary

@shahmishal shahmishal Awaiting requested review from shahmishal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edymtt @CodaFi @Rostepher @shahmishal