Skip to content

Add a high-level request to type check a file #28544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2019
Merged

Add a high-level request to type check a file #28544

merged 1 commit into from
Dec 4, 2019

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Dec 3, 2019

No description provided.

@CodaFi
Copy link
Contributor Author

CodaFi commented Dec 3, 2019

@swift-ci please test

DougGregor
DougGregor approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@DougGregor DougGregor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, but it's not "NFC" if we're changing the shape of requests.

@swift-ci
Copy link
Contributor

swift-ci commented Dec 4, 2019

Build failed
Swift Test OS X Platform
Git Sha - 2a8c6d3822e24b1dc905521382d73f88c52a7388

@CodaFi CodaFi force-pushed the file-unit-arianism branch from 2a8c6d3 to 371526b Compare December 4, 2019 01:16
@CodaFi CodaFi changed the title [NFC] Add a high-level request to type check a file Add a high-level request to type check a file Dec 4, 2019
@CodaFi
Copy link
Contributor Author

CodaFi commented Dec 4, 2019

@swift-ci please smoke test

@CodaFi
Copy link
Contributor Author

CodaFi commented Dec 4, 2019

⛵️

@CodaFi CodaFi merged commit 022ccd7 into swiftlang:master Dec 4, 2019
@CodaFi CodaFi deleted the file-unit-arianism branch December 4, 2019 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CodaFi @swift-ci @DougGregor