[Diagnostics] Add an educational note explaining closure type inference rules #28572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce rules This note explains the difference in type inference between single expression and non-single expression closures. It is associated with the "unable to infer complex closure return type" diagnostic.
|
Now that some more of the details around educational notes are sorted out I'm beginning to take a look at how they could supplement some of the more nuanced type inference diagnostics. It's still early days but I'd be interested in any feedback you have on the style & content of these. |
xedin
approved these changes
Dec 6, 2019
|
@swift-ci please smoke test |
|
Type-checker doesn't even try to infer anything in this case and just rolls with the context... |
|
@xedin I agree the short message could probably be improved. I had a hard time trying to come up with something better though. If I do, I'll add it in. |
|
Sounds good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This note explains the difference in type inference between single expression and non-single expression closures. It is associated with the "unable to infer complex closure return type" diagnostic when descriptive diagnostics are enabled.
Once #28313 lands I'll be able to add educational notes support to the verifier and add a test to this PR.