[build-script] Consistent use of shell.capture in swift_build_support #2858
Conversation
Eliminate direct `import subprocess`.
rintaro
force-pushed
the
build-script-capture
branch
from
6f0e599 to
308160a
Compare
|
@swift-ci Please Python lint |
|
@gribozavr @ddunbar Could we accept introducing |
| file=file) | ||
| version = shell.capture( | ||
| ['xcodebuild', '-version'], | ||
| dry_run=False, echo=False, optional=True).rstrip() |
There was a problem hiding this comment.
I'd rather we stop right here if the command fails. If xcodebuild is not there, we're in trouble.
There was a problem hiding this comment.
I agree.
Moreover, we need non-Darwin version of --show-sdks implementation.
In this PR, I will just omit , optional=True
|
LGTM, |
|
@swift-ci Please test |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test OS X platform |
|
@swift-ci Please smoke test |
|
Hm, the change list in CI looks funny. |
|
The smoke tests are incremental, so we get a list of commits compared to the last smoke test that was run (which is irrelevant). |
|
@swift-ci Please smoke test OS X platform |
|
Ah, got it :) |
What's in this pull request?
Replace
subprocess.check_callwithshell.captureinswift_build_supportpackage.This eliminates direct
subprocessimport. Currently, except formigrationmodule.Introduced
optionalparameter toshell.capture.Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Lint Testing
Note: Only members of the Apple organization can trigger swift-ci.