Skip to content

isCanonical should take the Clang function type into account only if UseClangFunctionTypes is enabled. #28580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 5, 2019
Merged

isCanonical should take the Clang function type into account only if UseClangFunctionTypes is enabled. #28580

merged 2 commits into from
Dec 5, 2019

Conversation

varungandhi-apple
Copy link
Contributor

Fixes rdar://problem/57644243.

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please test

@varungandhi-apple
Copy link
Contributor Author

@swift-ci please test source compatibility

rjmccall
rjmccall approved these changes Dec 5, 2019
View reviewed changes
Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xedin xedin merged commit 50fef73 into swiftlang:master Dec 5, 2019
@varungandhi-apple varungandhi-apple deleted the vg-fix-borked-isCanonical-calc branch December 5, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjmccall rjmccall rjmccall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varungandhi-apple @rjmccall @xedin