[Property wrappers] Fix crash due to wrapped type/wrapper type confusion #28589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. We had two predicates that were used to determine whether the default argument for a wrapped property in the memberwise initializer would be of the wrapper type (e.g., Lazy<Int>) vs. the wrapped type (Int). Those two predicates could disagree, causing a SILGen assertion and crash. Collapse the two predicates into one correct one, fixing rdar://problem/57545381.
|
@swift-ci please smoke test |
hborla
approved these changes
Dec 5, 2019
Perform implicit "nil" initialization for a wrapped property only when the memberwise initializer's parameter is of the wrapped type.
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
1 similar comment
|
@swift-ci please test source compatibility |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had two predicates that were used to determine whether the default
argument for a wrapped property in the memberwise initializer would be
of the wrapper type (e.g.,
Lazy<Int>) vs. the wrapped type(
Int). Those two predicates could disagree, causing a SILGen assertionand crash. Collapse the two predicates into one correct one,
fixing rdar://problem/57545381.