[Type checker]: Classes Hashable and Equatable synthesis diagnostic
#28633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mance on Classes 1. Added note for 'Hashable' and 'Equatable' protocol synthesis for classes.
theblixguy
reviewed
Dec 7, 2019
theblixguy
requested changes
Dec 7, 2019
|
@theblixguy Fixed diagnostic. Updated with tests. |
theblixguy
reviewed
Dec 7, 2019
theblixguy
reviewed
Dec 7, 2019
|
Let’s run some tests (there might be other test files that need updating). @swift-ci please smoke test |
CodaFi
reviewed
Dec 9, 2019
CodaFi
approved these changes
Dec 9, 2019
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SR-11902: Improve Error Message for Auto-synthesized Equatable Conformance on Classes
More information in ticket https://bugs.swift.org/browse/SR-11902
Resolves rdar://57316058