Skip to content

[AutoDiff] Move PullbackEmitter to a separate file. #28634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 7, 2019
Merged

[AutoDiff] Move PullbackEmitter to a separate file. #28634

merged 1 commit into from
Dec 7, 2019

Conversation

bgogul
Copy link
Contributor

@bgogul bgogul commented Dec 7, 2019

Final major refactoring for https://bugs.swift.org/browse/TF-993

@bgogul
Copy link
Contributor Author

bgogul commented Dec 7, 2019

@swift-ci please test tensorflow

@bgogul bgogul requested review from dan-zheng and rxwei December 7, 2019 16:20
dan-zheng
dan-zheng approved these changes Dec 7, 2019
View reviewed changes
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hurray! Thanks for the organization 🙂

@dan-zheng
Copy link
Contributor

Merging now to prevent accidental lost changes from updates to Differentiation.cpp.

@dan-zheng dan-zheng merged commit f0b1c0b into swiftlang:tensorflow Dec 7, 2019
@bgogul
Copy link
Contributor Author

bgogul commented Dec 7, 2019

Thanks for merging, Dan!

@bgogul bgogul deleted the move_pb_emitter branch December 7, 2019 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-zheng dan-zheng dan-zheng approved these changes

@rxwei rxwei Awaiting requested review from rxwei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bgogul @dan-zheng