SR-10689: Fix bugs of DataProtocol's firstRange(of:in:)/lastRange(of:in:). #28639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
I'm sorry. The failure is caused by my rudimentary mistake. I'll fix it. |
…f:in:) to fix SR-10689. Cherry-pick from swiftlang/swift-corelibs-foundation#2499
YOCKOW
force-pushed
the
sr-10689-cherry-pick
branch
from
0a5e93e to
421af22
Compare
|
I am sorry for the late fix. Now it is rebased and would pass tests. |
|
All tests of this PR and scf#2499 have passed. |
|
@phausler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataProtocol'sfirstRange(of:in:)andlastRange(of:in:)return a wrong value or crash under some conditions because they handle indices incorrectly.Resolves SR-10689.
Note: This PR is a counterpart of swiftlang/swift-corelibs-foundation#2499 .