[AutoDiff] Fix cloned curry thunk verification error. #28662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcrasi
approved these changes
Dec 9, 2019
|
@swift-ci Please test tensorflow |
Differentiation has special support for canonicalizing `differentiable_function` instructions of curry thunk applications: curry thunks are cloned to a version returning a `differentiable_function` of the original return value. In cloned curry thunks, the `differentiable_function` instruction is now created right after the return value's defining instruction, not at the end of the function. This avoids `alloc_stack`/`dealloc_stack` ordering issues. Resolves TF-1039.
|
@swift-ci Please clean test tensorflow |
1 similar comment
|
@swift-ci Please clean test tensorflow |
rxwei
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differentiation has special support for canonicalizing
differentiable_functioninstructions of curry thunk applications: curry thunks are cloned to a version
returning a
differentiable_functionof the original return value.In cloned curry thunks, the
differentiable_functioninstruction is nowcreated right after the returned value's defining instruction, not at the end of
the function. This avoids
stack_alloc/stack_deallocordering issues.Resolves TF-1039.