[build-script] Install SwiftSyntax to usr/lib instead of usr/lib/swift #28663
Conversation
|
@swift-ci Please test |
|
@swift-ci Please build toolchain |
|
Is |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
Build failed |
|
macOS Toolchain Install command |
SwiftSyntax is not part of the standard library and thus should not be installed in usr/lib/swift. This also removes the code to install SwiftSyntax's .swiftmodule file since that code path was never exercised.
ahoppen
force-pushed
the
install-swiftsyntax-usr-lib
branch
from
961db23 to
91ca8ca
Compare
|
Verified that the stress tester still runs in the new toolchain and that libSwiftSyntax now lives in /usr/lib Fixed some Python Lint errors, re-running CI to pick them up. @swift-ci Please smoke test |
|
@swift-ci please smoke test macOS platform |
|
Oh, forgot about this one. @swift-ci Please smoke test and merge |
|
@swift-ci Please smoke test |
|
@ahoppen seems that it has passed, I'll go ahead and merge :) |
|
@compnerd Thanks! |
SwiftSyntax in the toolchain is only needed to run the stress tester executable. If a third-party library wants to use it, they are supposed to depend on the SwiftPM package.
As such, SwiftSyntax should not be installed in
usr/lib/swiftwhere the standard library lives. This PR changes the install location of SwiftSyntax to beusr/lib.This also removes the code to install SwiftSyntax's
.swiftmoduleand.swiftdocfile since that code path was never exercised.