Explicitly State CodingKeys as a Codable Requirement #28665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Build failed |
CodaFi
force-pushed
the
the-phantom-menace
branch
from
0bcc686 to
d2136a3
Compare
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Build failed |
|
Infrastructure problems with the macOS build @swift-ci please smoke test macOS platform |
State the previously unstated nested type requirement that CodingKeys adds to the witness requirements of a given type. The goal is to make this member cheap to synthesize, and independent of the expensive protocol conformance checks required to append it to the member list. Further, this makes a clean conceptual separation between what I'm calling "nested type requirements" and actual type and value requirements. With luck, we'll never have to use this attribute anywhere else.
CodableConformanceType::TypeNotValidated is unused since the InterfaceTypeRequest changes went through. We can just use the validity of the ProtocolConformanceRef here.
The semantic checks for CodingKeys are being duplicated across the value witness synthesis code paths. Just synthesize a CodingKeys enum and let validateCodingKeysEnum do the heavy lifting when we actually need to go emit diagnostics.
The presence of this attribute will be used to guide the protocol derivation machinery to synthesize CodingKeys.
CodaFi
force-pushed
the
the-phantom-menace
branch
from
d2136a3 to
3bda241
Compare
|
Let's get this merged @swift-ci please smoke test |
|
⛵️ |
beccadax
added a commit
that referenced
this pull request
Jan 16, 2020
Revert "Merge pull request #28665 from CodaFi/the-phantom-menace"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the way we model the
CodingKeys"requirement" in Codable. The idea is that it should be cheap and easy to synthesizeCodingKeys. But it should also be clear thatCodablesynthesis has the unique ability to synthesize type witnesses to requirements that don't formally exist, hence "Phantom Requirements". This patch adds a new, terrifyingly-named, user-inaccessible attribute@_implicitly_synthesizes_nested_requirement, and attaches it toEncodableandDecodable. The synthesis machinery looks for the attribute and, if it must synthesize a value witness, attempts to install the phantom witness first.This pull request and #28624 together will let us eliminate
ImplicitMemberAction::ResolveEncodableandImplicitMemberAction::ResolveDecodable.Relates to rdar://56844567