Skip to content

[build] Reduce redundancy in setting cmark cmake options #28667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2019

Conversation

bulbazord
Copy link
Contributor

These lines are mostly the same (with macosx-x86_64 as the exception), so we should pull them out.

cc @shahmishal @compnerd

@bulbazord
Copy link
Contributor Author

@swift-ci please smoke test

@shahmishal
Copy link
Member

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 3d50fa8

@bulbazord
Copy link
Contributor Author

@swift-ci please test OS X Platform

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 3d50fa8

@bulbazord
Copy link
Contributor Author

I don't think that the failures on macOS are related here, but I'm unsure.

@bulbazord
Copy link
Contributor Author

@swift-ci please test OS X platform

@compnerd compnerd merged commit 3a24f59 into swiftlang:master Dec 11, 2019
@bulbazord bulbazord deleted the leaving-my-cmark branch December 11, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants