[windows] Switch ICU4C from SourceForge to GitHub. #28683
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please clean test Windows platform |
compnerd
approved these changes
Dec 11, 2019
Use GitHub download instead of SourceForge for ICU4C binary package, since SF fails from time to time and the build fails because of it. Also remove the usage of -z, since Community CI deletes the previous file anyway, so no point in checking for a cached copy, when the only thing that would happen is an annoying message in the build logs.
drodriguez
force-pushed
the
windows-switch-to-github-for-icu
branch
from
3ca3008 to
b368f7a
Compare
|
@swift-ci please test Windows platform [Edit: it actually has started in https://ci-external.swift.org/view/Pull Request/job/swift-PR-windows/234 and it seems that ICU has been downloaded and unzipped correctly this time] |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use GitHub download instead of SourceForge for ICU4C binary package, since SF fails from time to time and the build fails because of it.
Also remove the usage of -z, since Community CI deletes the previous file anyway, so no point in checking for a cached copy, when the only thing that would happen is an annoying message in the build logs.