[NameLookup] Add requests for module and AnyObject lookup (master) #28689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now have an equivalent counter for LookupInModuleRequest.
We now have an equivalent counter for AnyObjectLookupRequest.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
|
Hm, smoke test label jobs are a little eager today. |
CodaFi
approved these changes
Dec 11, 2019
|
@CodaFi I think it actually picked up the test results from the PR against |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
LookupInModuleRequestfor module-level lookup, andAnyObjectLookupRequestfor AnyObject lookup.This is a cherry-pick of #28395 to master.