[CS] Don't adjust opened types of @dynamicMemberLookup overloads #28694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than adjusting the opened types for choices referring to `subscript(dynamicMember:)` down to the result type, only use the result type to bind the overload type variable. This avoids the need for a couple of special cases in CSApply. To facilitate this change, add `ConstraintSystem::bindOverload`, which deals with adding the necessary constraints to bind the overload's type variable. The eventual goal here is to remove `adjustTypeOfOverloadReference`, with adjustments to the opened type being moved to `getTypeOfMemberReference`, and the adding of constraints being moved to `bindOverloadType`.
Now that overload binding for dynamic member lookup occurs after having recorded the `subscript(dynamicMember:)` overload, we can attempt simplification of this constraint right away.
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
xedin
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than adjusting the opened types for choices referring to
subscript(dynamicMember:)down to the result type, only use the result type to bind the overload type variable. This avoids the need for a couple of special cases in CSApply.To facilitate this change, add
ConstraintSystem::bindOverload, which deals with adding the necessary constraints to bind the overload's type variable. The eventual goal here is to removeadjustTypeOfOverloadReference, with adjustments to the opened type being moved togetTypeOfMemberReference, and the adding of constraints being moved tobindOverloadType.