[Runtime] Handle Error-conforming-to-NSObject casting fully. #28700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
Yikes, I thought #28406 had already been reverted with the rest. And it's still unfixed, thank you. |
|
D'oh. :( |
I missed a case where an Error-conforming class is dynamically casted to NSObject (via NSError). Fix it.
This prevents runtime differences on as? from affecting this test.
…SObject. Rather than attempting Error bridging early when trying to dynamically cast to NSError or NSObject, treat it as the *last* thing we do when all else fails. Push most of this code over into Objective-C-specific handling rather than #ifdef'd into the main casting logic to make that slightly more clear. One oddity of Error/NSError bridging is that a class that conforms to Error can be dynamically cast to NSObject via Error bridging. This has always been known to the static compiler, but the runtime itself was not always handling such a cast uniformly. Do so now, uniformly. However, this forced us to weaken an assertion, because casting a class type to NSError or NSObject can produce an object with a different identity. Fixes rdar://problem/57393991.
This reverts commit 29a6d10.
DougGregor
force-pushed
the
bridge-all-the-errors
branch
from
8767ec3 to
169dbcd
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please test macOS |
1 similar comment
|
@swift-ci please test macOS |
|
@swift-ci please test platform macOS |
|
Build failed |
|
@swift-ci please test platform macOS |
|
Build failed |
|
@swift-ci please test Linux |
|
I'm going to merge because other PRs will be built on top of this, but we'll back it out of there are any concerns. |
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than attempting Error bridging early when trying to dynamically
cast to NSError or NSObject, treat it as the last thing we do when
all else fails. Push most of this code over into Objective-C-specific
handling rather than #ifdef'd into the main casting logic to make that
slightly more clear.
One oddity of Error/NSError bridging is that a class that conforms to
Error can be dynamically cast to NSObject via Error bridging. This has
always been known to the static compiler, but the runtime itself was
not always handling such a cast uniformly. Do so now,
uniformly. However, this forced us to weaken an assertion, because
casting a class type to NSError or NSObject can produce an object with
a different identity.
Fixes rdar://problem/57393991.