Remove workaround for unnamed_addr constants for LLVM JIT #28704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JIT has been fixed in llvm r362139. rdar://51809210
|
@swift-ci Please test |
|
Can you commit the regression test in the radar as well, or is it already in? |
|
The workaround commit https://github.com/apple/swift/pull/24944/files added the regression test |
aschwaighofer
added a commit
to aschwaighofer/swift
that referenced
this pull request
Feb 26, 2020
The usage of private vars that seemingly are accessed accross object files confuses the JIT. rdar://59782487
aschwaighofer
added a commit
that referenced
this pull request
Feb 26, 2020
…around IRGen: Reinstate JIT workaround removed in PR #28704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JIT has been fixed in llvm r362139.
rdar://51809210