[ConstraintSystem] Port function parameter type mismatch diagnostics. #28712
Conversation
|
@swift-ci please smoke test |
| @@ -3543,19 +3543,21 @@ bool ConstraintSystem::repairFailures( | |||
|
|
|||
| // Drop the `tuple element` locator element so that all tuple element | |||
| // mismatches within the same tuple type can be coalesced later. | |||
| auto index = elt.getAs<LocatorPathElt::TupleElement>()->getIndex(); | |||
There was a problem hiding this comment.
Just to double-check - this is an intermediate step until we get ApplyArgToParam generalization, right?
There was a problem hiding this comment.
Much of this is intermediate until we get a generalized ApplyArgToParam locator - especially the getStructuralTypeContext function in CSFix.cpp. That function is filling in the contextual information that we're missing.
That said, this particular line of code is just to keep track of which tuple elements/parameters don't match (it was there before, previously on line 3556, I just moved it up).
There was a problem hiding this comment.
Sounds good! I just needed to put this comment on one of the lines because otherwise GitHub doesn't support discussion if I just leave it as review comment :)
|
@swift-ci please smoke test Linux platform |
This allows us to remove
diagnoseTrailingClosureErrorsfrom CSDiag.