Skip to content

[Driver, Incremental] Add enable- and disable- only-one-dependency-file flags #28743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2019
Merged

[Driver, Incremental] Add enable- and disable- only-one-dependency-file flags #28743

merged 2 commits into from
Dec 19, 2019

Conversation

davidungar
Copy link
Contributor

@davidungar davidungar commented Dec 12, 2019 •
edited
Loading

Since every make-style dependency file has the same contents, it wastes time to output one for each source file. Only write one real one, and create empty dummy files (to keep the build system happy) for the rest.

Latest version of this facility. Intervenes earlier in the driver in order to work well with batch mode.

Resolves rdar://57824038

@davidungar
Copy link
Contributor Author

@swift-ci please smoke test and merge

@davidungar davidungar force-pushed the enable-disable-on-by-default branch from aba119c to 8d8591c Compare December 12, 2019 18:51
@davidungar
Copy link
Contributor Author

@swift-ci please smoke test

2 similar comments
@davidungar
Copy link
Contributor Author

@swift-ci please smoke test

@davidungar
Copy link
Contributor Author

@swift-ci please smoke test

@davidungar davidungar requested a review from CodaFi December 13, 2019 06:16
@davidungar davidungar changed the title [Driver, Incremental] Add enable-only-one-dependency-file flag [Driver, Incremental] Add enable- and disable- only-one-dependency-file flags Dec 13, 2019
@davidungar davidungar force-pushed the enable-disable-on-by-default branch from 4a22976 to 4f61957 Compare December 13, 2019 20:37
@davidungar
Copy link
Contributor Author

@swift-ci please smoke test os x platform

@davidungar davidungar force-pushed the enable-disable-on-by-default branch from 4f61957 to 283dd5f Compare December 14, 2019 05:25
@davidungar
Copy link
Contributor Author

@swift-ci please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - aba119ce7216121c896fd4b1a57ae0e63b83ded0

@davidungar
Copy link
Contributor Author

@swift-ci please test OS X platform

@davidungar
Copy link
Contributor Author

@swift-ci please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - aba119ce7216121c896fd4b1a57ae0e63b83ded0

@davidungar
Copy link
Contributor Author

@swift-ci please test source compatibility debug

1 similar comment
@davidungar
Copy link
Contributor Author

@swift-ci please test source compatibility debug

@davidungar davidungar removed the request for review from DougGregor December 17, 2019 19:54
@davidungar
Copy link
Contributor Author

@swift-ci please test source compatibility debug

@davidungar davidungar force-pushed the enable-disable-on-by-default branch from 8523a12 to 96d61f7 Compare December 18, 2019 21:02
@davidungar
Copy link
Contributor Author

@swift-ci please test

@davidungar
Copy link
Contributor Author

@swift-ci please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - c239676799aaa7cc9939070f672f4c226d169824

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - c239676799aaa7cc9939070f672f4c226d169824

@davidungar davidungar force-pushed the enable-disable-on-by-default branch 2 times, most recently from c8e1d99 to 2a79331 Compare December 19, 2019 00:08
@davidungar
Copy link
Contributor Author

@swift-ci please test

@davidungar
Copy link
Contributor Author

@swift-ci please test source compatibility

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 96d61f76d1738d47644b0648fa97472046e27d6f

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 96d61f76d1738d47644b0648fa97472046e27d6f

@davidungar
Copy link
Contributor Author

@swift-ci please smoke test

@davidungar davidungar force-pushed the enable-disable-on-by-default branch from 2b08849 to b1f6a89 Compare December 19, 2019 15:39
@davidungar
Copy link
Contributor Author

@swift-ci please smoke test

@davidungar davidungar merged commit c03fbb5 into swiftlang:master Dec 19, 2019
@drodriguez
Copy link
Contributor

I am trying to figure out why the Windows CI started failing after merging this PR (https://ci-external.swift.org/job/oss-swift-windows-x86_64/2293/).

From what I understand this changes the default from emitting files with contents to emitting empty files. Just that, right?

@davidungar
Copy link
Contributor Author

@drodriguez This changes the default so that one job emits a real .d file and the driver creates empty .d files for the rest of them.

@davidungar
Copy link
Contributor Author

I am trying to figure out why the Windows CI started failing after merging this PR (https://ci-external.swift.org/job/oss-swift-windows-x86_64/2293/).

From what I understand this changes the default from emitting files with contents to emitting empty files. Just that, right?

Please let me know what you discover. Tx!

@davidungar davidungar mentioned this pull request Dec 20, 2019
Closed
@davidungar
Copy link
Contributor Author

I see the problem, but not the fix (yet)--looks like the dummy file syntax is wrong for windows.

@drodriguez
Copy link
Contributor

I think one might need to call open() to actually create the file?

@igor-makarov igor-makarov mentioned this pull request Dec 13, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodaFi CodaFi Awaiting requested review from CodaFi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidungar @swift-ci @drodriguez