Skip to content

[CSDiag] Remove obsolete function diagnostics from visitApplyExpr #28783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Dec 13, 2019

  • Extend new diagnostics to properly handle optional Object-C methods
  • Diagnose invalid calls on Any and AnyObject
  • Remove obsolete logic from CSDiag

@xedin xedin requested a review from hborla December 13, 2019 22:10
@xedin
Copy link
Contributor Author

xedin commented Dec 13, 2019

@swift-ci please smoke test

@slavapestov
Copy link
Contributor

CSDiag is now under 3000 lines with this change.

@xedin
Copy link
Contributor Author

xedin commented Dec 14, 2019

Looks like this conflicted with Slava's PR :)

… on Any/AnyObject

Detect and diagnose situations where call is attempted directly on
`Any` or `AnyObject` or member calls with `AnyObject` base which
didn't match.
@xedin xedin force-pushed the cut-down-fn-retypecheck-in-visit-applye-expr branch from 1d0cace to 2db14a9 Compare December 14, 2019 06:51
@xedin
Copy link
Contributor Author

xedin commented Dec 14, 2019

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented Dec 14, 2019

@swift-ci please smoke test macOS platform

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Dec 16, 2019

@swift-ci please smoke test macOS platform

@xedin xedin merged commit a96c40d into swiftlang:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants