[NFC] Refactor name parsing into parseDeclNameRef()
#28801
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives this functionality a more self-documenting interface.
|
@swift-ci please test |
|
Build failed |
rintaro
reviewed
Dec 16, 2019
|
@swift-ci please test linux platform |
|
Build failed |
|
Possibly a flaky test. @swift-ci please test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser currently has two DeclNameRef-parsing functions,
parseUnqualifiedDeclName()andparseUnqualifiedDeclBaseName(), which take four undifferentiatedbools to control their behavior. I will soon need yet another flag, so this is getting a bit out of hand.This PR replaces them with a
parseDeclNameRef()function and a flag enum to control these behaviors. This should improve the readability of existing code and help accommodate future flag additions.