Unset IFS after its use in set_build_options_for_host #28811
Conversation
If IFS remains set, it may cause compilation errors due to unanticipated replacement of characters in some parameters. Addresses rdar://problem/57927748
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
|
||
| for target in "${DARWIN_SDK_DEPLOYMENT_TARGETS[@]}"; do | ||
| local IFS="-"; triple=($target) | ||
| local IFS="-"; triple=($target); unset IFS |
There was a problem hiding this comment.
Can you add a comment explaining why this is important?
There was a problem hiding this comment.
Rationale explanation added as part of c1bdb4f
There was a problem hiding this comment.
I wonder if we can get away with some regular expressions instead of using ifs and trying to parse out the triple. We really want to discourage people doing much in this script. But, if thats not easy, this is okay to merge. It is correcting a defect, which existed previously.
|
@swift-ci please test |
|
@swift-ci please test Windows |
|
Build failed |
|
Build failed |
|
@swift-ci please test Windows |
|
@swift-ci please clean test Windows |
|
@swift-ci please test OS X |
If IFS remains set, it may cause compilation errors due to unanticipated
replacement of characters in some parameters.
Addresses rdar://problem/57927748