Skip to content

Use -[NSSet getObjects:] instead of -[NSSet getObjects:count:] to maintain compatibility with existing code passing NSArrays into this function #28829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

Catfish-Man
Copy link
Contributor

5.2 version of #28817

Fixes rdar://57801853

…ntain compatibility with existing code passing NSArrays into this function

(cherry picked from commit 257c93a)
@Catfish-Man Catfish-Man self-assigned this Dec 17, 2019
@Catfish-Man Catfish-Man changed the base branch from master to swift-5.2-branch December 17, 2019 17:02
@Catfish-Man Catfish-Man requested a review from lorentey December 17, 2019 17:02
Copy link
Member

@lorentey lorentey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@kylemacomber kylemacomber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the test

@Catfish-Man
Copy link
Contributor Author

@swift-ci please smoke test and merge

@Catfish-Man
Copy link
Contributor Author

@swift-ci please test and merge

@swift-ci swift-ci merged commit e41ae93 into swiftlang:swift-5.2-branch Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants