[build-script] Introduce "concat" argument action #2884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get rid of unnecessary list of list argument.
rintaro
force-pushed
the
build-script-args-concat
branch
from
706a0b1 to
0d6e1b1
Compare
|
@swift-ci Please test |
|
Yes, thanks!!
|
| @@ -955,7 +955,7 @@ details of the setups of other systems or automated environments.""") | |||
| help="Pass through extra options to CMake in the form of comma " | |||
| "separated options '-DCMAKE_VAR1=YES,-DCMAKE_VAR2=/tmp'. Can be " | |||
There was a problem hiding this comment.
Is the comment still accurate? It seems like the list is space-separated, or rather, shell-script-style.
There was a problem hiding this comment.
Not so accurate:(
Accept both comma and space.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Introduce
concatinswift_build_support.arguments.actionmodule.This simplifies list like arguments processing: avoid unnecessary "list of list".
Before merging this pull request to apple/swift repository: