Skip to content

update-checkout: use semantic revision #28851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 23, 2019

Conversation

compnerd
Copy link
Member

Use the semantic name (v2.1.0-rc1) instead of an explicit ref to make it
easier to identify the revision in use.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@compnerd
Copy link
Member Author

@swift-ci please test tensorflow

@marcrasi
Copy link

Sometimes we have to clean test when we change the update-checkout-config.json. I'll try triggering that.

@marcrasi
Copy link

@swift-ci please clean test tensorflow

@dan-zheng
Copy link
Contributor

dan-zheng commented Dec 18, 2019

CI fails with this error:

Updating '/home/swiftci/jenkins/workspace/swift-PR-TensorFlow-Linux/swift-tools-support-core'
Error on repo "/home/swiftci/jenkins/workspace/swift-PR-TensorFlow-Linux/swift-tools-support-core": Traceback (most recent call last):
  File "/home/swiftci/jenkins/workspace/swift-PR-TensorFlow-Linux/swift/utils/update_checkout/update_checkout/update_checkout.py", line 91, in update_single_repository
    config, repo_name, scheme_name, scheme_map, cross_repos_pr)
  File "/home/swiftci/jenkins/workspace/swift-PR-TensorFlow-Linux/swift/utils/update_checkout/update_checkout/update_checkout.py", line 58, in get_branch_for_repo
    scheme_branch = scheme_map[repo_name]
KeyError: u'swift-tools-support-core'

This error occurs because CI was last triggered for the tensorflow-merge -> tensorflow PR #28847, which involved changes to update-checkout-config.json.

Sometimes, CI machines are left in an incompatible state after testing tensorflow-merge -> tensorflow PRs, so a clean test (@swift-ci Please clean test tensorflow) is necessary.

This error should naturally go away when #28847 is merged soon today. I'd recommend waiting for that PR to be merged before this one, to unblock the master -> tensorflow merge and to avoid merge conflicts.

Use the semantic name (v2.1.0-rc1) instead of an explicit ref to make it
easier to identify the revision in use.
@compnerd compnerd force-pushed the tensorflow-revision branch from 60bb272 to 8ae01d0 Compare December 19, 2019 03:02
@compnerd
Copy link
Member Author

@swift-ci Please clean test tensorflow

@compnerd
Copy link
Member Author

@swift-ci please clean test tensorflow

@dan-zheng
Copy link
Contributor

@swift-ci Please clean test tensorflow

@dan-zheng
Copy link
Contributor

dan-zheng commented Dec 23, 2019

CI fails:

You have bazel 0.26.1 installed.
Please upgrade your bazel installation to version 0.27.1 or higher to build TensorFlow!

I'll upgrade Bazel on all CI machines to 0.29.1 (the max supported version) now.

@dan-zheng
Copy link
Contributor

@swift-ci Please test tensorflow

@compnerd compnerd merged commit 5a6236b into swiftlang:tensorflow Dec 23, 2019
@compnerd compnerd deleted the tensorflow-revision branch December 23, 2019 19:23
@AnthonyLatsis AnthonyLatsis added the update-checkout Area → utils: the `update-checkout` script label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants