[Driver, Incremental] Add enable- and disable- only-one-dependency-file flags off-by-default #28867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
davidungar
force-pushed
the
enable-disable-off-by-default
branch
from
1270e5d to
f48db4d
Compare
|
@swift-ci please smoke test |
davidungar
force-pushed
the
enable-disable-off-by-default
branch
from
f48db4d to
0291b36
Compare
|
@swift-ci please smoke test |
CodaFi
approved these changes
Dec 19, 2019
davidungar
pushed a commit
to davidungar/swift
that referenced
this pull request
Dec 20, 2019
…-by-default [Driver, Incremental] Add enable- and disable- only-one-dependency-file flags off-by-default
davidungar
pushed a commit
to davidungar/swift
that referenced
this pull request
Dec 23, 2019
…-by-default [Driver, Incremental] Add enable- and disable- only-one-dependency-file flags off-by-default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only enabled if the driver is passed -enable-only-one-dependency-file
Since every make-style dependency file has the same contents, it wastes time to output one for each source file. Only write one real one, and create empty dummy files (to keep the build system happy) for the rest.
Latest version of this facility. Intervenes earlier in the driver in order to work well with batch mode.
Landing this PR first, planning to land a separate one turning the feature on-by-default. That way, it can be easily disabled.
Preparatory for rdar://57824038