Skip to content

Unrevert EscapeAnalysis commits #28871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Dec 19, 2019
Merged

Unrevert EscapeAnalysis commits #28871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b926af
EscapeAnalysis: Add PointerKind and interior/reference flags
atrick Dec 17, 2019
7fb4e21
EscapeAnalysis: Make EscapeState and UsePoints a property of the cont…
atrick Dec 17, 2019
17ab0ad
EscapeAnalysis: Do not create defer edges for block arguemnts.
atrick Dec 17, 2019
3782d67
EscapeAnalysis: rewrite canEscapeToUsePoint.
atrick Dec 17, 2019
6dfbafb
EscapeAnalysis: Add and update tests.
atrick Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
358 changes: 216 additions & 142 deletions include/swift/SILOptimizer/Analysis/EscapeAnalysis.h
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions lib/SILOptimizer/Analysis/AliasAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,8 +737,8 @@ bool AliasAnalysis::mayValueReleaseInterfereWithInstruction(SILInstruction *User
// The most important check: does the object escape the current function?
auto LO = getUnderlyingObject(V);
auto *ConGraph = EA->getConnectionGraph(User->getFunction());
auto *Node = ConGraph->getNodeOrNull(LO);
if (Node && !Node->escapes())
auto *Content = ConGraph->getValueContent(LO);
if (Content && !Content->escapes())
return false;

// This is either a non-local allocation or a scoped allocation that escapes.
Expand Down
Loading