Skip to content

[Clang importer] objc_direct methods/properties are unavailable in Swift #28886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions lib/ClangImporter/ImportDecl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7555,6 +7555,15 @@ void ClangImporter::Implementation::importAttributes(
}
}

if (auto method = dyn_cast<clang::ObjCMethodDecl>(ClangDecl)) {
if (method->isDirectMethod() && !AnyUnavailable) {
auto attr = AvailableAttr::createPlatformAgnostic(
C, "", "", PlatformAgnosticAvailabilityKind::UnavailableInSwift);
MappedDecl->getAttrs().add(attr);
AnyUnavailable = true;
}
}

// If the declaration is unavailable, we're done.
if (AnyUnavailable)
return;
Expand Down
12 changes: 12 additions & 0 deletions test/ClangImporter/Inputs/objc_direct.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
@interface Bar
@property (readonly, direct, nonatomic) int directProperty;
- (void)directMethod __attribute__((objc_direct));
+ (void)directClassMethod __attribute__((objc_direct));
@end

__attribute__((objc_direct_members))
@interface Bar ()
@property (readonly, nonatomic) int directProperty2;
- (void)directMethod2;
+ (void)directClassMethod2;
@end
14 changes: 14 additions & 0 deletions test/ClangImporter/objc_direct.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
// RUN: %target-swift-frontend-verify -typecheck %s -enable-objc-interop -import-objc-header %S/Inputs/objc_direct.h -verify-ignore-unknown

// REQUIRES: objc_interop

func callThingsOnBar(_ x: Bar) {
let _ = x.directProperty // expected-error {{getter for 'directProperty' is unavailable in Swift}}
let _ = x.directProperty2 // expected-error {{getter for 'directProperty2' is unavailable in Swift}}

x.directMethod() // expected-error {{'directMethod()' is unavailable in Swift}}
x.directMethod2() // expected-error {{'directMethod2()' is unavailable in Swift}}

Bar.directClassMethod() // expected-error {{'directClassMethod()' is unavailable in Swift}}
Bar.directClassMethod2() // expected-error {{'directClassMethod2()' is unavailable in Swift}}
}