Skip to content

[AutoDiff] rename @nondiff to @noDerivative #28887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2019

Conversation

marcrasi
Copy link

This cherrypicks the upstream @noDerivative PR (#28278) into tensorflow. The effect is so rename @nondiff to @noDerivative. We keep @nondiff for now, with a deprecation warning.

@marcrasi marcrasi requested a review from dan-zheng December 20, 2019 00:17
@dan-zheng dan-zheng requested a review from rxwei December 20, 2019 00:29
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@marcrasi
Copy link
Author

@swift-ci please test tensorflow

@dan-zheng dan-zheng merged commit 959ffb0 into tensorflow Dec 20, 2019
@dan-zheng dan-zheng deleted the marcrasi-rename-nondiff branch December 20, 2019 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants