[Typechecker] Fix duplicate diagnostics when using attributes #28888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… after emitting a diagnostic, to prevent duplicate diagnostics later
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
xedin
reviewed
Dec 20, 2019
…pts a TypeRepr and invalidates it
|
@xedin Sure thing, I have done that now! |
xedin
reviewed
Dec 20, 2019
|
@swift-ci please smoke test |
|
I have added @rintaro as a reviewer as well since he spend some time on type resolution as well. |
rintaro
approved these changes
Dec 20, 2019
kitaisreal
pushed a commit
to kitaisreal/swift
that referenced
this pull request
Dec 22, 2019
…ang#28888) * [Typechecker] resolveAttributedType() should invalidate the type repr after emitting a diagnostic, to prevent duplicate diagnostics later * [Test] Update '@NoEscape' attribute diagnostics * [Typechecker] Add a special diagnose method to TypeResolver that accepts a TypeRepr and invalidates it * [Typechecker] Rename the special 'diagnose' method to 'diagnoseInvalid' for clarity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not invalidating the
TypeReprafter diagnosing inresolveAttributedType, which meant that trying to resolving the type for the sameTypeReprwould result in the same diagnostic multiple times.It seems to affect just
@autoclosureand@escapingin some cases (and@noescapewhich is not supported anymore), but I've applied the invalidation in all cases to future proof this.Resolves SR-9178