[AutoDiff] forbid @derivative of protocol req #28890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Thanks @marcrasi ! |
dan-zheng
approved these changes
Dec 20, 2019
|
@swift-ci please test tensorflow |
marcrasi
force-pushed
the
marcrasi-forbid-retrodiff-protocol-req
branch
from
d5aed23 to
4b4111b
Compare
|
swift-ci caught a simple failure. Should be fixed now. @swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
3 similar comments
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
|
@swift-ci please test tensorflow |
|
Merging now! Changes can be upstreamed after the holiday freeze. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until TF-982 is implemented,
@derivatives of protocol requirements don't do anything. Therefore, this PR forbids them and adds a test that they are forbidden.I am doing this because it fixes a problem that prevents me from removing
vjp:fromFloatingPoint.squareRoot. The problem is that you get an "ambiguous reference" error because it can't tell if you want the@derivativeon the requirement or the default implementation. This PR also adds a test that this problem is fixed (protocol HasADefaultImplementation).The portions of this PR in code that have been upstreamed should be upstreamed. I will do this in a separate PR after merging this PR, because I want to run this PR through our full
tensorflow-specific test suite.