Skip to content

Revert "[test] Mark _Differentiable tests as unsupported in Swift-in-the-OS configurations" #28893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2019
Merged

Revert "[test] Mark _Differentiable tests as unsupported in Swift-in-the-OS configurations" #28893

merged 1 commit into from
Dec 20, 2019

Conversation

lorentey
Copy link
Member

Reverts #28882

The issue was due to a misconfiguration; these tests are already marked unsupported in back deployment setups.

rdar://57975086

@lorentey
Copy link
Member Author

cc @dan-zheng

@lorentey
Copy link
Member Author

@swift-ci smoke test and merge

dan-zheng
dan-zheng approved these changes Dec 20, 2019
View reviewed changes
Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, and for providing context!

@lorentey lorentey merged commit d61de7d into master Dec 20, 2019
@lorentey lorentey deleted the revert-28882-master branch December 20, 2019 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dan-zheng dan-zheng dan-zheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lorentey @dan-zheng