[CodeCompletion] Eliminate CodeCompletionCallbacks::completeExpr() #28898
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
benlangmuir
approved these changes
Dec 20, 2019
Well, this does nothing. It just set the parser position twice and calls the consumer's 'handleResults()' without any reason. It seems it was intended to be a "fallback" completion, but it was never implemented properly. So just remove it for now. rdar://problem/58102910
rintaro
force-pushed
the
ide-completion-rdar58102910
branch
from
1028424 to
ab04751
Compare
|
Rebased to resolve a conflict |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well, this does nothing. It just set the parser position twice and calls the consumer's
handleResults()without any reason.It seems it was intended to be a "fallback" completion, but it was never implemented properly. So just remove it for now.
rdar://problem/58102910