[CodeCompletion] Reduce accumulating memory per fast completion #28904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
rintaro
force-pushed
the
ide-completion-rdar58119719
branch
from
810f778 to
f42b736
Compare
|
@swift-ci Please smoke test |
1 similar comment
|
@swift-ci Please smoke test |
For each fast completion, the memory grows for the source buffer and the AST of the function body in memory. They are kept until the next slow completion. To mitigate the memory consumption per completion, use sliced source text which is actually required for the second pass. rdar://problem/58119719
This improves diangostics message for completion traces
rintaro
force-pushed
the
ide-completion-rdar58119719
branch
from
2dc88a3 to
108b9c3
Compare
|
@swift-ci Please smoke test |
rintaro
changed the title
benlangmuir
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each fast completion, the memory grows for the source buffer and the AST of the function body. They are kept until the next slow completion.
To mitigate the memory consumption per completion, use sliced source text which is actually needed for the second pass.
rdar://problem/58119719