Skip to content

ModuleInterface: preserve AutolinkForceLoad option when generating .swiftmodule from .swiftinterface #28912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2020

Conversation

nkcsgexi
Copy link
Contributor

This change ensures using .swiftmodule built from source has the same behavior as
using .swiftmodule built from .swiftinterface.

A swift-ide-test utility is added to print linked libraries from a Swift module for
testing purposes.

rdar://58057556

@nkcsgexi
Copy link
Contributor Author

@swift-ci please smoke test

@nkcsgexi nkcsgexi force-pushed the auto-link-force-load branch from 6187e04 to a2acbdc Compare January 2, 2020 20:58
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Jan 2, 2020

@swift-ci please smoke test

1 similar comment
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Jan 6, 2020

@swift-ci please smoke test

@nkcsgexi nkcsgexi force-pushed the auto-link-force-load branch from a2acbdc to 29596b6 Compare January 6, 2020 19:29
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Jan 6, 2020

@swift-ci please test

@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Jan 6, 2020

@lorentey As we discussed earlier, I've changed the cmake configs for Vision and several other overlays to search libraries inside SDK.

@swift-ci
Copy link
Contributor

swift-ci commented Jan 6, 2020

Build failed
Swift Test Linux Platform
Git Sha - 6187e04435bc0f011b3eeed727691013851fd59e

@swift-ci
Copy link
Contributor

swift-ci commented Jan 6, 2020

Build failed
Swift Test OS X Platform
Git Sha - 6187e04435bc0f011b3eeed727691013851fd59e

@nkcsgexi nkcsgexi force-pushed the auto-link-force-load branch from f7e320f to 7e9afca Compare January 7, 2020 00:08
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Jan 7, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jan 7, 2020

Build failed
Swift Test OS X Platform
Git Sha - f7e320fac437c52e44285fb4931cfe022f610fc6

@swift-ci
Copy link
Contributor

swift-ci commented Jan 7, 2020

Build failed
Swift Test Linux Platform
Git Sha - f7e320fac437c52e44285fb4931cfe022f610fc6

@nkcsgexi nkcsgexi force-pushed the auto-link-force-load branch from 7e9afca to 3674922 Compare January 7, 2020 02:40
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Jan 7, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jan 7, 2020

Build failed
Swift Test Linux Platform
Git Sha - 7e9afca3060bdfb39454ebb328f9e28ab583b05d

@swift-ci
Copy link
Contributor

swift-ci commented Jan 7, 2020

Build failed
Swift Test OS X Platform
Git Sha - 7e9afca3060bdfb39454ebb328f9e28ab583b05d

@nkcsgexi nkcsgexi force-pushed the auto-link-force-load branch from 3674922 to a3c1902 Compare January 7, 2020 02:43
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Jan 7, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jan 7, 2020

Build failed
Swift Test Linux Platform
Git Sha - 36749224eec92c4cc9bae16af801b995c5ad8ae3

@swift-ci
Copy link
Contributor

swift-ci commented Jan 7, 2020

Build failed
Swift Test OS X Platform
Git Sha - 36749224eec92c4cc9bae16af801b995c5ad8ae3

…wiftmodule from .swiftinterface

This change ensures using .swiftmodule built from source has the same behavior as
using .swiftmodule built from .swiftinterface.

A swift-ide-test utility is added to print linked libraries from a Swift module for
testing purposes.

rdar://58057556
…urce

When force linking auto-linked libraries, an overlay will fail to link if the dependence
libraries are missing from the source. This change provides linker flags
to search overlay libraries from the SDK.
@nkcsgexi nkcsgexi force-pushed the auto-link-force-load branch from a3c1902 to 7a1ac6b Compare January 7, 2020 05:17
@nkcsgexi
Copy link
Contributor Author

nkcsgexi commented Jan 7, 2020

@swift-ci please test

@swift-ci
Copy link
Contributor

swift-ci commented Jan 7, 2020

Build failed
Swift Test OS X Platform
Git Sha - a3c1902498a89eb8bd6f09d51c4dde9a159fd02d

@swift-ci
Copy link
Contributor

swift-ci commented Jan 7, 2020

Build failed
Swift Test Linux Platform
Git Sha - a3c1902498a89eb8bd6f09d51c4dde9a159fd02d

@nkcsgexi nkcsgexi merged commit 3fa5011 into swiftlang:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants