Refactoring tests for CollectionOfOne #2894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| OneTests.test("Basic tests") { | ||
| for x in CollectionOfOne(2) { | ||
| expectEqual(2, x) | ||
| } |
There was a problem hiding this comment.
The test used to check not only the values, but also that the loop only did one iteration -- could you add a counter as well?
|
@frootloops Thank you! LGTM modulo a small comment. |
|
@swift-ci Please smoke test |
frootloops
force-pushed
the
collection-of-one
branch
from
e06ca5e to
13f83a0
Compare
|
@gribozavr check it again please |
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.