[CodeCompletion] Batch code completion test #28946
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rintaro
force-pushed
the
ide-completion-batchtest-rdar16025703
branch
from
78a60c1 to
d3d2a31
Compare
rintaro
force-pushed
the
ide-completion-batchtest-rdar16025703
branch
from
d3d2a31 to
d69cc9b
Compare
rintaro
force-pushed
the
ide-completion-batchtest-rdar16025703
branch
from
d69cc9b to
4b617e7
Compare
rintaro
force-pushed
the
ide-completion-batchtest-rdar16025703
branch
from
4b617e7 to
524342d
Compare
rintaro
commented
Jun 18, 2020
| } | ||
|
|
||
| func testTypeInTupleType7() { | ||
| var localVar: (a: b: #^TYPE_IN_TUPLE_TYPE_7^# | ||
| var localVar: (a: b: #^TYPE_IN_TUPLE_TYPE_7?skip=FIXME^# |
There was a problem hiding this comment.
This was not checked. i.e. no RUN: line was there.
Comment on lines
-1151
to
+752
| extension Task.Inner.#^UNBOUND_DOT^# {} | ||
| func testUnbound(x: Task.Inner.#^UNBOUND_DOT^#) {} | ||
| extension Task.Inner.#^UNBOUND_DOT_1?check=UNBOUND_DOT^# {} | ||
| func testUnbound(x: Task.Inner.#^UNBOUND_DOT_2?check=UNBOUND_DOT^#) {} |
There was a problem hiding this comment.
UNBOUND_DOT used to be duplicated.
|
@swift-ci Please smoke test |
rintaro
commented
Jun 18, 2020
rintaro
force-pushed
the
ide-completion-batchtest-rdar16025703
branch
from
524342d to
4f9202b
Compare
|
@swift-ci Please smoke test |
benlangmuir
reviewed
Jun 18, 2020
| llvm::errs() << "Elapsed: " << elapsed.count() << " msec\n"; | ||
| OS.flush(); | ||
|
|
||
| if (OutputDir.empty()) { |
There was a problem hiding this comment.
I was surprised that empty output dir implies skipping filecheck. Should we make it an error to have no output dir unless you also have --dont-filecheck ?
There was a problem hiding this comment.
Not specifying '-completion-output-dir' is now error unless -skip-filecheck
Utilize fast-completion in swift-ide-test
rintaro
force-pushed
the
ide-completion-batchtest-rdar16025703
branch
from
4f9202b to
f99fa56
Compare
benlangmuir
approved these changes
Jun 18, 2020
akyrtzi
approved these changes
Jun 18, 2020
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilize fast completion (reusing
CompilerInstance) in libIDE code completion tests.complete_types.swift)Introduce
-batch-code-completionmode. The typical usage is:This scans the source file for tokens (
#^NAME^#), then performs code completion for each token in random order withreuseastcontextmode.Options are:
-filecheck:FileCheckcommand path. Completion results are checked with thisFileCheck-completion-output-dir: Temporary file directory. Completion results are output with${output dir}/complete-${token name}.result-random-seed: By default, tokens are shuffled with random generated seed. Using-random-seedyou can specify shuffle seed. This is convenient for reproducing order-dependent failures-code-completion-token: You can specify a specific token name to test, but inbatch-code-completionmodeEach token can have several options (e.g.
#^NAME?check=GLOBAL;comments=true^#):check: By default, the completion results areFileCheck -check-prefixes=ed with the token name.checkcan changes thecheck-prefixname. Also, you can specify multiplecheckto perform multipleFileChecks with different prefixeskeywords: equivalent to-code-completion-keywordscomments: equivalent to-code-completion-commentsskip: Tokens withskipare skippedIn this PR. Only migrate
test/IDE/complete_type.swift. But I intend to migrate other test files in follow up PRs.rdar://problem/16025703